This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Refactor Swift Demo and Document #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keefertaylor
requested review from
a team,
dino-rodriguez and
0xCLARITY
and removed request for
a team
keefertaylor
requested review from
amiecorso
and removed request for
dino-rodriguez
|
+Amie who now knows Swift |
amiecorso
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Yes I am now a resident expert for SF office. Looks good to me. A question for learning: when it comes to updating the dependency versions like in the Cartfile or the Cartfile.resolved... are you doing that manually? Or are these changes originating from something automatic when you rebuild the project or something? And if they're manual, where are you looking to make sure you have the version right?
Merged
keefertaylor
added a commit
that referenced
this pull request
Feb 27, 2020
* readme * node demo and docs * node demo * demo image * node demo * update ci * Refactor Swift Demo and Document (#8) * wip * remove swift demo * base infra to work with carthage * deinit some submodules * Update README.md * more source * more finicking with xcode * remove carthage * remove frameworks * working demo * working CI / demo * rename file * minor polish * add circle config * Update README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add README (main and swift).
Context of Change
Building out demos.
Type of Change
Before / After
N/A
Test Plan
CI